Skip to content

Add cpp unordered set reverse #8136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Sriparno08 merged 16 commits into from
Jan 30, 2026
Merged

Add cpp unordered set reverse #8136

Sriparno08 merged 16 commits into from
Jan 30, 2026

Conversation

@dejongbaba
Copy link
Contributor

@dejongbaba dejongbaba commented Jan 6, 2026

Description

[Term Entry] C++ Unordered sets end function: reserve()

Issue Solved

Closes #8050

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@mamtawardhani mamtawardhani self-assigned this Jan 7, 2026
@mamtawardhani
Refine reserve() documentation for unordered_set
361d7bc 
Updated the description and notes for the reserve() function in std::unordered_set. Added details about return value and clarified usage.
mamtawardhani
mamtawardhani previously requested changes Jan 8, 2026
View reviewed changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dejongbaba, the entry looks good! 😄

Could you please remove the querySelectorAll.md file from this branch? Thanks!

@dejongbaba
Copy link
Contributor Author

dejongbaba commented Jan 8, 2026

Hey @dejongbaba, the entry looks good! 😄

Could you please remove the querySelectorAll.md file from this branch? Thanks!

Hi @mamtawardhani, thank you for your response, I've removed it from the branch, you can see it in this commit b9b1580
or is there something I'm missing? hopefully its fine and my update can be merged because this is the second time you're pointing this out and my previous PR 8091 has not been merged yet as well, I want to get this out of the way as soon as possible. Let me know what to do, thank you.

@Sriparno08 Sriparno08 added status: under review Issue or PR is currently being reviewed and removed status: waiting for author labels Jan 30, 2026
@Sriparno08 Sriparno08 self-assigned this Jan 30, 2026
Sriparno08
Sriparno08 approved these changes Jan 30, 2026
View reviewed changes
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @dejongbaba!

@Sriparno08 Sriparno08 dismissed mamtawardhani’s stale review January 30, 2026 12:13

Changes already applied.

@Sriparno08 Sriparno08 merged commit 63c5291 into Codecademy:main Jan 30, 2026
7 checks passed
@github-actions
Copy link

github-actions bot commented Jan 30, 2026

👋 @dejongbaba
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/cpp/unordered-set/reserve

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, visit the linked accounts page and ensure that your GitHub account is linked.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sriparno08 Sriparno08 Sriparno08 approved these changes

@mamtawardhani mamtawardhani mamtawardhani left review comments

Assignees

@mamtawardhani mamtawardhani

@Sriparno08 Sriparno08

Labels

c++ C++ entries new entry New entry or entries status: review 1️⃣ completed status: review 2️⃣ completed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Term Entry] C++ Unordered-sets :reserve()

3 participants

@dejongbaba @mamtawardhani @Sriparno08